admin/bump-readlif-for-multi-scene #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Readlif` has been update to better handle scene names that have a parent/child structure. This change addresses the issue originally reported here: AllenCellModeling#277 Bumping the version requirement on `readlif` is a significant quality-of-life improvement for `aicsimageio` users, as well as the new multi-scene reading widget in `napari-aicsimageio`. For example, in the case of multi-well experiments, regions of interest may have the same names (R1, R1 ...), but the parent (well) names will differ (A1, B2, etc.).
Codecov Report
@@ Coverage Diff @@
## main #327 +/- ##
==========================================
- Coverage 94.46% 94.30% -0.17%
==========================================
Files 40 40
Lines 3018 3018
==========================================
- Hits 2851 2846 -5
- Misses 167 172 +5
Continue to review full report at Codecov.
|
evamaxfield
requested review from
evamaxfield,
AetherUnbound,
MatteBailey and
toloudis
evamaxfield
approved these changes
Oct 3, 2021
|
I’ve been running this readlif branch since before the widget change. I was surprised when I first worked on it that the complex scene names JustWorked™️. But they do. I guess the string processing everywhere is safe. |
toloudis
approved these changes
Oct 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Readlifhas been update to better handle scene names that have a parent/child structure.This change addresses the issue originally reported here: #277
Bumping the version requirement on
readlifis a significant quality-of-life improvement foraicsimageiousers, as well as the new multi-scene reading widget innapari-aicsimageio. For example, in the case of multi-well experiments, regions of interest may have the same names (R1, R1 ...), but the parent (well) names will differ (A1, B2, etc.). See:You can see the scene names are "rich", including enclosing parent information, not just "R1", "R1_Merged".
Pull request recommendations:
Thanks for contributing!